-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaces mpp_recv and mpp_send and uses mpi_gather and mpi_scatterv within mpp_scatter_pelist #1240
Open
ganganoaa
wants to merge
18
commits into
NOAA-GFDL:main
Choose a base branch
from
ganganoaa:mpi_scatterv
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ganganoaa - can you include this new version in parallel with the existing version? This will allow us evaluate performance in many different scenarios via different test cases. |
It has issues with non-MPI compilation. So, I am updating it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The original mpp_scatter used point-to-point communications: _mpp_recv and mpp_send to gather at and scatter from the root pe. This update replaces the point-to-point communications and uses standard collective communications: mpi_gather and mpi_scatterv to achieve the data transfer.
Fixes # (issue)
How Has This Been Tested?
Tested locally with Intel oneAPI (v2023.1.0); intel ifort (v2021.9.0).
Checklist:
make distcheck
passes